Skip to content

FIX: enhanced nbdkit command detection and usage #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

414n
Copy link

@414n 414n commented Aug 4, 2025

On some Linux distributions (like Slackware Linux), directories like /sbin and /usr/sbin are not included in the default PATH for regular users. As a result, attempting to launch nbdkit as is done in lib/nbdkit.ml fails at runtime because the binary is typically installed in /usr/sbin.

This PR does the following:

  1. detect nbdkit earlier at configure time in guestfs-progs.m4, by explicitly searching it also in /usr/sbin and /sbin. Failure to detect it results in a warning message in order to keep it as an optional dependency;
  2. inject the detected path in the Config module, but keeping it an option type;
  3. refactor lib/nbdkit.ml to use the detected path instead of the hardcoded nbdkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant