FIX: enhanced nbdkit
command detection and usage
#98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Linux distributions (like Slackware Linux), directories like
/sbin
and/usr/sbin
are not included in the defaultPATH
for regular users. As a result, attempting to launchnbdkit
as is done inlib/nbdkit.ml
fails at runtime because the binary is typically installed in/usr/sbin
.This PR does the following:
nbdkit
earlier at configure time inguestfs-progs.m4
, by explicitly searching it also in/usr/sbin
and/sbin
. Failure to detect it results in a warning message in order to keep it as an optional dependency;Config
module, but keeping it anoption
type;lib/nbdkit.ml
to use the detected path instead of the hardcodednbdkit
.