feat: add option to specify hosted zone ID#261
Merged
aymanbagabas merged 2 commits intolibdns:masterfrom Jul 31, 2024
Merged
Conversation
For cases where the automatic discovery doesn't work (e.g. when we're creating a certificate for "foo.bar.com", and have a zone for "bar.com" that we can create the challenge records in). Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
Collaborator
aymanbagabas
left a comment
aymanbagabas
left a comment
There was a problem hiding this comment.
looks good, some comments below
| // HostedZoneID is the ID of the hosted zone to use. If not set, it will | ||
| // be discovered from the zone name. | ||
| // | ||
| // It must be in the format "/hostedzone/Z01111111111111111111". |
Collaborator
There was a problem hiding this comment.
This is not very usable imo. Could you make this simply take the zone ID Z01111111111111111111?
Contributor
Author
There was a problem hiding this comment.
@aymanbagabas Changed to just take the zone ID and updated the comment; please take a look? I can squash the fixup commit if that looks good.
Collaborator
There was a problem hiding this comment.
No worries, I can squash the commit before merging.
Collaborator
aymanbagabas
left a comment
aymanbagabas
left a comment
There was a problem hiding this comment.
LGTM! Thank you @andrew-d
Collaborator
|
@andrew-d Since this also would affect caddy-dns/route53, could you send a PR to add the new option using Caddyfile? https://github.com/caddy-dns/route53/blob/master/route53.go#L62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For cases where the automatic discovery doesn't work (e.g. when we're creating a certificate for
foo.bar.com, and have a zone forbar.comthat we can create the challenge records in).