fix: fetching more than 300 records resulted in duplicates#126
Merged
mholt merged 1 commit intolibdns:masterfrom Jun 24, 2024
Merged
fix: fetching more than 300 records resulted in duplicates#126mholt merged 1 commit intolibdns:masterfrom
mholt merged 1 commit intolibdns:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #127
ListResourceRecordSetsreturns up to 300 entries. When there are more than 300 entries, on each iteration the records are appended torecordSets, but it is looped each time, causing the loop to re-iterate and having many duplicates in the returned resultgo mod tidy