Conversation
Previously the various *Context() methods called the non-context methods together with a goroutine to watches the context and send a cancel query on the context cancellation. This changes it to make the *Context() methods the primary methods, and removing or stubbing out the non-context ones. This cleans up a bunch of old pre-Go 1.9 code, and is also required to use the context in more places, such as network timeouts. database/sql never uses Exec() or Query() if the *Context() variants are implemented. These can safely be removed outright. Similarly, conn.Prepare(), conn.Begin(), stmt.Exec(), and stmt.Query() are also never called if the context variants are implemented, but we need to keep them around to satisfy driver.Conn and driver.Stmt. Make them panic to ensure it's not accidentally called from pq code or tests. This shouldn't change any behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the various *Context() methods called the non-context methods together with a goroutine to watches the context and send a cancel query on the context cancellation. This changes it to make the *Context() methods the primary methods, and removing or stubbing out the non-context ones.
This cleans up a bunch of old pre-Go 1.9 code, and is also required to use the context in more places, such as network timeouts.
database/sql never uses Exec() or Query() if the *Context() variants are implemented. These can safely be removed outright.
Similarly, conn.Prepare(), conn.Begin(), stmt.Exec(), and stmt.Query() are also never called if the context variants are implemented, but we need to keep them around to satisfy driver.Conn and driver.Stmt. Make them panic to ensure it's not accidentally called from pq code or tests.
This shouldn't change any behaviour