Added Feature to strikethrough TODO items #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Requires adding -DNCURSES_WIDECHAR=1 to CFLAGS in src/Makefile 3. Made change so that priority cannot be changed on Completed TODO items. Signed-off-by: gaurav-cheema <[email protected]>
|
Is there an ETA on this ? |
|
Thanks for the PR and for the ping. I think this still needs a fair bit of work (e.g., in terms of code quality, code formatting, likely missing changes to the build system, ...) I also believe we may want to make this optional/configurable, or at least ensure everything works on legacy systems. |
|
@gaurav-cheema - I know it's been a while but would you be interested in turning this into a proper PR; i.e., making the feature configurable, integrating it with the build system, and bringing code quality/formatting in line with the rest of the codebase? |
lfos
force-pushed
the
pu
branch
2 times, most recently
from
d6eb6e7 to
d81b00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Feature to strikethrough TODO items
Requires adding -DNCURSES_WIDECHAR=1 to CFLAGS in src/Makefile
Made change so that priority cannot be changed on Completed TODO items.