[11.0-stable] backport: Make newlogd keep the original msg text and fields

[europaul]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4972221) 20.30% compared to head (df61816) 20.30%.

Additional details and impacted files

@@             Coverage Diff              @@
##           11.0-stable    #3733   +/-   ##
============================================
  Coverage        20.30%   20.30%           
============================================
  Files              212      212           
  Lines            46071    46071           
============================================
+ Hits              9354     9355    +1     
- Misses           36034    36035    +1     
+ Partials           683      681    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eriknordmark]

LGTM

[eriknordmark]

I see that eden tests are failing due to references to #cloud-config i.e., the tests assume that this support is present in 11.0-stable, which it doesn't seem to be. Are we referring to the wrong version/tag of the eden tests?

[europaul]

I see that eden tests are failing due to references to #cloud-config i.e., the tests assume that this support is present in 11.0-stable, which it doesn't seem to be. Are we referring to the wrong version/tag of the eden tests?

Thank you for noticing this @eriknordmark! Although the Eden version is set correctly to use the workflow from release 0.9.2, it still checks out the repository (including test files) from the latest master. I'm gonna look into this and present a fix, but this will probably have nothing to do with this PR.

[eriknordmark]

Thank you for noticing this @eriknordmark! Although the Eden version is set correctly to use the workflow from release 0.9.2, it still checks out the repository (including test files) from the latest master. I'm gonna look into this and present a fix, but this will probably have nothing to do with this PR.

I wonder if there is some fluke because the PR with the idential backport to 10.4-stable didn't trip on this.
I'll re-run eden once it has all failed.

[europaul]

Thank you for noticing this @eriknordmark! Although the Eden version is set correctly to use the workflow from release 0.9.2, it still checks out the repository (including test files) from the latest master. I'm gonna look into this and present a fix, but this will probably have nothing to do with this PR.

I wonder if there is some fluke because the PR with the idential backport to 10.4-stable didn't trip on this. I'll re-run eden once it has all failed.

The workflow has changed in 11.0-stable to use the workflow from Eden which works like this

When checking out the repository that triggered a workflow, this defaults to the reference or SHA for that event. Otherwise, uses the default branch.

So since we trigger that workflow from outside it just uses the latest master.

[eriknordmark]

So since we trigger that workflow from outside it just uses the latest master.

Can you check with @uncleDecart if we can come up with a better scheme. He and Avi has just redone the Eden workflows in master and I don't know if that would help or hinder coming up with a scheme for running the correct version of the eden tests for a stable branch. In any case I suspect we will need a general solution to this for future LTS releases.

[uncleDecart]

Trying to re-trigger eden tests 🪄

[eriknordmark]

Run eden

[uncleDecart]

Hadouken 🔥 (running eden test)

[uncleDecart]

🏃 🏃 🏃