Skip to content

Conversation

@Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Oct 30, 2025

No description provided.

odaysec and others added 3 commits October 30, 2025 12:38
Signed-off-by: Jörmungandrk <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 38.88889% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.40%. Comparing base (8a59ad3) to head (3e5a43e).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
internal/service/manager.go 14.29% 4 Missing and 2 partials ⚠️
internal/server/rule_manager.go 0.00% 3 Missing and 1 partial ⚠️
internal/pkg/filex/zip.go 25.00% 2 Missing and 1 partial ⚠️
internal/plugin/native/manager.go 25.00% 2 Missing and 1 partial ⚠️
internal/schema/registry.go 0.00% 2 Missing and 1 partial ⚠️
pkg/path/path.go 72.73% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3911      +/-   ##
==========================================
- Coverage   71.42%   71.40%   -0.02%     
==========================================
  Files         453      453              
  Lines       51923    52120     +197     
==========================================
+ Hits        37082    37214     +132     
- Misses      11942    11991      +49     
- Partials     2899     2915      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@odaysec odaysec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
@ngjaying ngjaying merged commit 58362b0 into lf-edge:master Nov 6, 2025
67 of 70 checks passed
ngjaying pushed a commit that referenced this pull request Nov 21, 2025
Signed-off-by: Jörmungandrk <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Co-authored-by: Jörmungandrk <[email protected]>
ngjaying pushed a commit that referenced this pull request Nov 21, 2025
Signed-off-by: Jörmungandrk <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Co-authored-by: Jörmungandrk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants