test: rewrite CAA integration test in Go #8340
Merged
+122
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also gets rid of the special casing for good-caa-reserved.com
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
|
Hi bot! Hope your circuits are flowing nicely today. The configuration changes are removing some overrides that are test-only; no relevant to prod. Thanks for pointing it out. |
beautifulentropy
previously approved these changes
Aug 15, 2025
test/integration/validation_test.go
Outdated
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| fmt.Printf("domain %s\n", domain) |
There was a problem hiding this comment.
Looks like a debug printf line here:
Suggested change
| fmt.Printf("domain %s\n", domain) |
beautifulentropy
requested review from
a team and
aarongable
and removed request for
a team
aarongable
previously approved these changes
Aug 15, 2025
aarongable
dismissed stale reviews from beautifulentropy and themself
via
fa6f98f
jprenken
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test case tested accounturi and validationmethods. Replace it with two test cases, one for validationmethods and one for accounturi. Use a random base domain to avoid rate limit issues.
Fixes #8332