Add CheckBox animation #1512
Open
Add CheckBox animation #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
controls
|
Thinking about it a little more, we can still do the idea of #1511, but now with the right properties to take the logical width into account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Replacement of #1511. The animation I've added is a little different from WinUI, which slides in from left to right. This is quite difficult to recreate in WPF. My initial idea to animate based on CheckBoxIconSize doesn't work reliably given the actual size is calculated based on the underlying glyph / TextBlock, and is sometimes larger. The new animation is now just a fade in based on opacity.
Wpf.Ui.Gallery_EMhJHl7yVJ.mp4