Enable ui:NavigationView.IsScrollable="False" on Page #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
github-actions
bot
added
controls
There was a problem hiding this comment.
Pull Request Overview
This PR implements an attached property IsScrollable for NavigationView that allows disabling scrolling in the NavigationView content presenter. The feature addresses issue #1503 by providing developers control over whether page content should be scrollable within the NavigationView.
- Added
IsScrollableattached property to control content scrolling behavior - Enhanced NavigationView template parts to locate and manage the content ScrollViewer
- Created demo page showing ListView with disabled NavigationView scrolling
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| NavigationViewContentPresenter.xaml | Added x:Name to content ScrollViewer for programmatic access |
| NavigationView.TemplateParts.cs | Added template part definition and logic to find content ScrollViewer |
| NavigationView.Navigation.cs | Added scroll behavior update logic when navigating to new content |
| NavigationView.AttachedProperties.cs | Implemented IsScrollable attached property definition |
| InternalNotifyIconManager.cs | Updated context menu placement using SetCurrentValue |
| NotifyIcon.cs | Enhanced DataContext handling for tray icon context menus |
| MainWindow.xaml.cs | Added tray menu event handling functionality |
| ListViewScrollPage files | Created demo page showcasing the new IsScrollable feature |
| MainWindowViewModel.cs | Updated tray menu items with icons and enhanced structure |
| ListViewViewModel.cs | Added big array generation for scroll testing |
src/Wpf.Ui.Gallery/Views/Pages/Collections/ListViewScrollPage.xaml.cs
Outdated
Show resolved
Hide resolved
src/Wpf.Ui.Gallery/ViewModels/Pages/Collections/ListViewScrollViewModel.cs
Outdated
Show resolved
Hide resolved
src/Wpf.Ui.Gallery/Views/Pages/Collections/ListViewScrollPage.xaml.cs
Outdated
Show resolved
Hide resolved
joesdu
changed the title
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: # 1503
What is the new behavior?
Allows page scrolling to be disabled (use ui:NavigationView.IsScrollable="False"), allowing controls such as ListView and ListBox to automatically use the remaining space and display the scrollbar.
Other information