Skip to content

Conversation

Nuklon
Copy link

@Nuklon Nuklon commented Jul 4, 2025

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Fixes 3 issues.

  1. Currently the Primary appreance button sort of gets moved up due to missing MouseOverBrush. You can see this here:
    image
    Right one has mouse over.
  2. Adds an alternative border thickness (0,0,0,1) for buttons with colors. Right now it used 1,1,1,1 but this
    a. doesn't match WinUI style
    b. causes the border shadow to flow over the sides. Fixed version:
    image

@Nuklon Nuklon requested a review from pomianowski as a code owner July 4, 2025 11:35
@Nuklon Nuklon changed the title Fix button brushes with appreance Fix button brushes with appearance Jul 4, 2025
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request release labels Jul 4, 2025
@Nuklon Nuklon changed the title Fix button brushes with appearance Fix buttons with appearance Jul 4, 2025
@Nuklon
Copy link
Author

Nuklon commented Jul 4, 2025

  1. Also fixed the border brush when selected. With WinUI, the pressed border brush is identical to the background of the button, (and not transparent).

@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Jul 30, 2025
@Nuklon
Copy link
Author

Nuklon commented Aug 6, 2025

Fixed remaining colors, they now look almost identical to WinUI. Depends on #1492.

@Nuklon
Copy link
Author

Nuklon commented Aug 6, 2025

Comparison (WinUI left, WPFUI right):
image

@github-actions github-actions bot removed the ⭐ top pull request Top pull request. label Aug 9, 2025
@Nuklon
Copy link
Author

Nuklon commented Aug 11, 2025

New version added with an inset border, which is sort of what WinUI also does.

@Nuklon
Copy link
Author

Nuklon commented Aug 28, 2025

7a3eff8 fixes dark mode secondary buttons having persistent border. Also added some comments to clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. PR Pull request release styles Topic is related to styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant