Sync to thomasvl/protobuf head#2
Merged
leovitch merged 2605 commits intoleovitch:masterfrom May 21, 2018
Merged
Conversation
…ed with meaningful description
Add tests to cover all the common special casing in the runtime code to ensure things come out correctly.
Fix uploading binary wheel.
remove nullptr
Add caliper supported to java benchmark
whitelisting aix platform as it has sched_yield
Merge 3.5.x branch into master
Bump protoc-artifact version for a patch rebuild
Previously, within the same load period of protobuf module, well known types are not initialized correctly for the second request. The reason is that well known type are only initialized if a method local static variable is not set. However, that variable is not reset after request ends. Therefore, when the second request comes, the method local static variable is still set (by previous request) and well types are not initialized in this case.
Found with PVS-Studio static analyser, see https://www.viva64.com/en/b/0550/
Better test coverage for datetime validation.
…k_real Add python benchmark
Java caliper counter
Fix ValidateDateTime: check day instead month
Add more tests to time_test
…Reset, format some files
Fix java benchmark to use parser, fix cpp benchmark new arena to use …
By default, unknown fields are preserved when parsing. To discard them, use a parser configured to do so: var parser = MyMessage.Parser.WithDiscardUnknownFields(true);
…harder to track down (protocolbuffers#3371)
Add dashboard support
…3_tools Add gogo benchmark
The current 15.6.x versions of Visual Studio 2017 contain a bug that prevent them from compiling the following construct under certain conditions: std::unique_ptr<std::unique_ptr<Foo> []> foos; This will fail to compile if Foo is an abstract class. To work-around the problem the whole construct was change into: std::vector<std::unique_ptr<Foo>> foos; This not only fixes the compiler error but is also more readable than previous version.
…hmark_build fix java benchmark, fix dashboard build
…ld_fix Fixed a Visual Studio 2017 build error. (protocolbuffers#4488)
Cleanup + documentation for Java Lite runtime.
…lbuffers#4440) * Edited MessageFieldGenerator to clone to backing field instead of property * Generated C# proto code
…hmark_build Fix benchmark build
The tests can run as what Apple calls a Logic Test (under xctest), which means it doesn't have to load an full UI App under the simulator, which speeds things up a fair amount.
Set ext.no_native = true for non mac platform
With this fix, Unity using IL2CPP should work with one of two approaches: - Call `FileDescriptor.ForceReflectionInitialization<T>` for every enum present in generated code (including oneof case enums) - Ensure that IL2CPP uses the same code for int and any int-based enums The former approach is likely to be simpler, unless IL2CPP changes its default behavior. We *could* potentially generate the code automatically, but that makes me slightly uncomfortable in terms of generating code that's only relevant in one specific scenario. It would be reasonably easy to write a tool (separate from protoc) to generate the code required for any specific set of assemblies, so that Unity users can include it in their application. We can always decide to change to generate it automatically later.
CMake: Update CXX Standard management
…protocolbuffers#4556) * Fix memory leak of exceptions raised by RaiseException() Currently exceptions raised by RaiseException() is never deallocated because: * ARC is disabled for this library: https://github.com/google/protobuf/blob/master/BUILD#L913 * It is constructed with `+alloc` but is never `-release`d. This change fixes the issue by using `-[NSException exceptionWithName:...]` instead, which returns an autoreleased instance, so it is deallocated properly. * Fix format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch up to head