Legit status deleted file support, minor UI overhaul#1420
Legit status deleted file support, minor UI overhaul#1420vindarel merged 5 commits intolem-project:mainfrom
status deleted file support, minor UI overhaul#1420Conversation
status deleted file support, minor overhaulstatus deleted file support, minor UI overhaul
|
LGTM I was delighted to be able to pick Lem sources to start legit and I delighted to see another contributor can pick up my legit code. Thanks for doing it. |
|
minor but necessary: please look at porcelain.lisp and legit.lisp top-level comments and at the README for the TODOs and update what's now done. |
|
@vindarel Thanks for the kind words! I removed the missing file TODO from |
|
This is nice. A cool next step could be to implement a |
absolutely. |
This PR adds support for deleted files in Legit. It also incidentally overhauls a bit of the status UI.
Here's the before/after:

Change summary:
Deleted files don't have a diff preview as of right now, instead there's just a message stating the file has been deleted. Should probably be revisited at some point to have the deleted file's contents show up.
Also, I'm unfamiliar with Mercurial and Fossil. I attempted to keep it compatible, but I was unable to test properly on Fossil (couldn't commit with/without my changes). Mercurial is mostly fine, the only gripe is that while deleted files show fine in the UI, trying to stage them does nothing. If I had to guess the issue is probably here:
Feel free to suggest or just make any changes!