Conversation
|
|
||
| (defun tokens (boundary strings) | ||
| (let ((alternation | ||
| `(:alternation ,@(sort (copy-list strings) #'> :key #'length)))) |
There was a problem hiding this comment.
Would (list …) and alexandria:flatten do the job instead of ,@? (didn't test this case)
(taking the assumption that stupid code is better)
|
Great! I left comments (I'm a helping hand). Could you add a paragraph on the features this brings? Here, or on the package's I saw:
re style: I would define lists / property lists with the default |
|
@vindarel Thank you for your review & suggestions! I'll try to adapt & extend the PR, based on them. |
| ### Language Server | ||
|
|
||
| Erlang mode will connect to your local ELP [Erlang Language Platform](https://github.com/WhatsApp/erlang-language-platform) installation. | ||
| Configure the ELP binary's location by setting *lsp-elang-elp-server-path*: |
There was a problem hiding this comment.
watch out, "*" needs to be escaped in code: `*foo*`
|
LGTM cool, thanks. If the PR is ready you can add cxxxr as reviewer, I'll let him merge. |
|
I think it's good and I merged. |
3 participants
First version of an Erlang mode. Improvements are certainly possible and welcome.
Currently configured for the Whatsapp ELP Erlang language server, but the Erlang LS could certainly be used as well.