Add a feature to disable undo boundary temporarily#1034
Merged
cxxxr merged 1 commit intolem-project:mainfrom Sep 4, 2023
Merged
Add a feature to disable undo boundary temporarily#1034cxxxr merged 1 commit intolem-project:mainfrom
cxxxr merged 1 commit intolem-project:mainfrom
Conversation
Closed
Member
|
Thank you for the nice PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to enable/disable auto undo boundary addition temporarily.
This feature is required in vi-mode to take all modifications done while in INSERT mode as a single undo stack.
I made it in a hacky way in vi-mode (ref #991), but it's not perfect since Lem automatically adds an undo boundary after every command invocation. For example, Lem adds a boundary even after completion.
Take this as a feature request with a code. I'm fine if the feature is done in a different way. Any advice is welcome.