Skip to content

feat(Combinatorics/SimpleGraph): hamiltonians graphs don't contain bridges#36802

Open
YaelDillies wants to merge 3 commits intoleanprover-community:masterfrom
YaelDillies:bridge_not_hamiltonian
Open

feat(Combinatorics/SimpleGraph): hamiltonians graphs don't contain bridges#36802
YaelDillies wants to merge 3 commits intoleanprover-community:masterfrom
YaelDillies:bridge_not_hamiltonian

Conversation

@YaelDillies
Copy link
Contributor

Replace the longer proof which assumed that the vertex set has at least three elements.


Open in Gitpod

…t in `Walk.rotate`

It is annoying for it not to appear in the infoview. In general, no implicit data argument to a definition should be inferrable only through proof arguments.
…bridge

Replace the longer proof which assumed that the vertex set has at least three elements.
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Mar 18, 2026
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

PR summary 2352820370

Import changes exceeding 2%

% File
+29.97% Mathlib.Combinatorics.SimpleGraph.Hamiltonian

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Combinatorics.SimpleGraph.Hamiltonian 594 772 +178 (+29.97%)
Import changes for all files
Files Import difference
Mathlib.Combinatorics.SimpleGraph.Hamiltonian 178

Declarations diff

+ IsBridge.nontrivial
+ IsBridge.not_isHamiltonian
+ IsCircuit.of_rotate
+ IsCycle.of_rotate
+ IsHamiltonian.exists_isHamiltonianCycle
+ IsHamiltonian.finite
+ IsHamiltonianCycle.finite
+ IsHamiltonianCycle.of_rotate
+ IsHamiltonianCycle.rotate
+ IsTrail.isEdgeReachable_two
+ IsTrail.isEdgeReachable_two_of_isEdgeReachable_two
+ IsTrail.isEdgeReachable_two_of_isEdgeReachable_two_aux
+ IsTrail.of_rotate
+ isCircuit_rotate
+ isCycle_rotate
+ isHamiltonianCycle_rotate
+ isTrail_rotate
+ length_rotate
+ not_isHamiltonianCycle_of_infinite
+ not_isHamiltonian_of_infinite
+ rotate_eq_nil
- IsTrail.not_mem_edges_of_not_isEdgeReachable_two
- not_isHamiltonian_of_isBridge

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-combinatorics Combinatorics label Mar 18, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 18, 2026
@mathlib-dependent-issues
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant