V5 - fix support for Laravel 5.7 and 5.8 (fixes #339, #351, #329, #334, #271, #365) #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to some changes in the Laravel internals in regard with handling eager loading, upgrading the library to Laravel 5.7 is required. Also, nobody should be on PHP < 7 anyway. So now is a good time, if any...
…zychaser#339, lazychaser#351, lazychaser#329, lazychaser#334, lazychaser#271) The way eager loading is handled in Laravel has changed since the original implementation of the NestedSet library. It was not possible anymore to apply the scope to eagerly loaded ancestors/descendants relationships. Also removed defaultOrder() from the relations so custom orders can be applied. Sorting should never be a part of a relation anyway, or it would be hard to customize.
Ciaro
changed the title
|
Is this abandoned package? Any fork who applied this PR? |
|
Thank you for the merge, @lazychaser However, I do believe you will need to make a new version tag (v5). |
|
why v5? |
|
As described in the PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you very much for this great library!
However, the way eager loading is handled in Laravel has changed since the
original implementation of the NestedSet library. In the current version v4 it is not possible
any more to apply the scope to eagerly loaded ancestors/descendants
relationships.
There are numerous tickets indicating this problem. This PR fixes those issues by creating a new v5 with support for Laravel 5.7 and Laravel 5.8 (because of the possible BC towards lower versions).
I took a couple of liberties (upgraded PHPUnit and the minimum PHP version). The unit tests pass again on Laravel 5.7 and up.
Let me know if you would require more info on the topic.
Best regards,
Ciaro