Skip to content

Conversation

yash37158
Copy link
Contributor

Description
This PR significantly improves the copy-to-clipboard user experience in the Sistent color code page by adding enhanced visual feedback, accessibility features, and better error handling while maintaining the project's coding patterns.

This PR fixes #6716

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Aug 19, 2025

🚀 Preview for commit 7886749 at: https://68a459cd6d6f5b00c943dd27--layer5.netlify.app

@Namanv0509
Copy link
Member

@yash37158 , the hovering from one token to other changes the shape of table rapidly due to copy text , we might want to look over it .

Also i think changing only background of token when copied can be best , currently the text color also changes to black causing visual issues.

@l5io
Copy link
Contributor

l5io commented Aug 19, 2025

🚀 Preview for commit c8928b7 at: https://68a49c73d44d4e74c86cb0c7--layer5.netlify.app

@yash37158
Copy link
Contributor Author

@Namanv0509, I'll fix that

@vr-varad
Copy link
Contributor

Also
image
@yash37158

@l5io
Copy link
Contributor

l5io commented Aug 19, 2025

🚀 Preview for commit 87238f6 at: https://68a4daff620625a07764dae6--layer5.netlify.app

Signed-off-by: yash37158 <[email protected]>
@yash37158
Copy link
Contributor Author

Both the issues are fixed @Namanv0509 @vr-varad

@l5io
Copy link
Contributor

l5io commented Aug 19, 2025

🚀 Preview for commit df788ff at: https://68a4defff7f92d3f6c7de366--layer5.netlify.app

@vr-varad
Copy link
Contributor

  1. On clicking the Copy button, the button disappears but not the space
image
  1. Does this happen with you, clicking after clicking on diff copy leaves a green patch or is it a feature?
image

// @yash37158 @Namanv0509

@l5io
Copy link
Contributor

l5io commented Aug 20, 2025

🚀 Preview for commit bc53c8c at: https://68a58e0fdec8f2d30915c093--layer5.netlify.app

@yash37158
Copy link
Contributor Author

@vr-varad, i have updated the overall behaviour here which is more appealing.

@l5io
Copy link
Contributor

l5io commented Aug 20, 2025

🚀 Preview for commit 1c18094 at: https://68a5b0a609058f6eb41b173c--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 21, 2025

🚀 Preview for commit 398b7e7 at: https://68a6e486888f5d8549ec56b9--layer5.netlify.app

@yash37158 yash37158 requested a review from vr-varad August 21, 2025 09:31
@vr-varad
Copy link
Contributor

@yash37158 Still has the tag of pr/do-not-merge, anything remaining? I reverted the changes for feature_data.json.

@l5io
Copy link
Contributor

l5io commented Aug 22, 2025

🚀 Preview for commit 68b545e at: https://68a80f4189039ca79d26ad33--layer5.netlify.app

@yash37158
Copy link
Contributor Author

No, we are good to merge this. I have removed the tag @vr-varad

@l5io
Copy link
Contributor

l5io commented Aug 22, 2025

🚀 Preview for commit 2a8199d at: https://68a86551180ea3009dcfc7c7--layer5.netlify.app

@vr-varad
Copy link
Contributor

@yash37158 Just wanna confirm, are u able to see the Copied Notification on the mobile screen.

@yash37158
Copy link
Contributor Author

yash37158 commented Aug 22, 2025

Yes its visible. Just Let me fix this as the notification is being cut.
Screenshot 2025-08-23 at 12 13 35 AM

@l5io
Copy link
Contributor

l5io commented Aug 22, 2025

🚀 Preview for commit cfb0a7d at: https://68a8c2546df1127b4426120a--layer5.netlify.app

@yash37158
Copy link
Contributor Author

Hi @vr-varad can you please revert those changes done by @l5io. idk why it keeps pushing changes to this PR.

@l5io
Copy link
Contributor

l5io commented Aug 28, 2025

🚀 Preview for commit 8e75615 at: https://68affd3b308c876bf41bd48e--layer5.netlify.app

@vr-varad vr-varad merged commit 1d74873 into layer5io:master Aug 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants