Skip to content

fix: put Package.resolved into gitignore #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelonogov-ld merged 2 commits into from
Oct 29, 2025
Merged

fix: put Package.resolved into gitignore #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45a6e21
fix: put Package.resolved into gitignore
abelonogov-ld Oct 28, 2025
48ad749
delete
abelonogov-ld Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ DerivedData/
.swiftpm/configuration/registries.json
.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
.netrc
**/Package.resolved
Package.resolved
Copy link
Copy Markdown

@cursor cursor bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gitignore Regression: Package.resolved Files Not Ignored

The gitignore pattern was changed from **/Package.resolved to Package.resolved, which is a regression. The original pattern **/Package.resolved matches Package.resolved files at any directory level (recursively), while the new pattern Package.resolved only matches files at the root directory. This means Package.resolved files in subdirectories will no longer be ignored, allowing them to be accidentally committed.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Contributor Author

@abelonogov-ld abelonogov-ld Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need only root

Copy link
Copy Markdown

@cursor cursor bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Root Directory Matching Issue

The pattern Package.resolved will match at any directory level, not just the root. To match only at the root as intended ("we need only root"), the pattern should be /Package.resolved with a leading slash. Both **/Package.resolved and Package.resolved match recursively through subdirectories; only the leading slash restricts matching to the root directory.

Fix in Cursor Fix in Web

257 changes: 0 additions & 257 deletions Package.resolved
View file
Open in desktop

This file was deleted.