fix "NSArray was mutated while being enumerated" #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwhelanLD
approved these changes
Sep 8, 2020
gwhelanLD
left a comment
gwhelanLD
left a comment
There was a problem hiding this comment.
Hi @RangerRick,
Thanks for the PR. Looks like your change should fix the issue. Normally index iteration would also be unsafe, but it should be okay as we never remove elements from the array of listeners.
As a note we're deprecating this library, as we've moved our iOS client SDK to to use https://github.com/launchdarkly/swift-eventsource instead. We'll be accepting bug fixes until July 2021, at which point we'll be dropping support.
I'll merge this and we'll have a patch release out soon.
Thanks again,
@gwhelanLD
Merged
gwhelanLD
added a commit
that referenced
this pull request
Sep 11, 2020
## [4.1.1] - 2020-09-11 ### Fixed - Thanks to @RangerRick fo PR [#32](#32), fixing "NSArray was mutated while being enumerated" exceptions when adding listeners while events are being dispatched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes processing event handlers so it iterates the array of listeners the old-fashioned way -- by index -- rather than using
in handlers, in order to avoid "mutated while being enumerated" errors.I ran into this when using the code with my Capacitor plugin because I was adding and removing event listeners in different bits of my client code somewhat regularly.