Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
The PR updates the Prometheus discovery endpoint to surface real HTTP errors instead of silently returning null, improving error transparency.
- Replace
return nullwith thrown status codes for HTTP and application-level failures. - Ensure actual HTTP response statuses are propagated on discovery errors.
app/api/discovery/route.ts
Outdated
Comment on lines
+23
to
+29
| throw response.status; | ||
| } | ||
|
|
||
| const { data, status }: PrometheusQueryResponse = await response.json(); | ||
|
|
||
| if (status !== "success") { | ||
| return null; | ||
| throw 500; |
There was a problem hiding this comment.
[nitpick] Throwing a raw number makes it harder to include context or stack information; consider throwing an Error (e.g. throw new Error(Discovery failed: ${response.statusText})) or returning a NextResponse with the status code and message for clearer error handling.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run lint(fails:nextnot found)npm install(fails: Exit handler never called)