Converter internals unification #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CNugteren
commented
Jan 7, 2022
| } | ||
| } | ||
|
|
||
| Status GetNumInputs(mlir::OwningModuleRef* module, int* num_inputs) { |
There was a problem hiding this comment.
This function was copied 1-to-1 from saved_model_tfl_flatbuffer.cc.
CNugteren
commented
Jan 7, 2022
| return Status::OK(); | ||
| } | ||
|
|
||
| pybind11::bytes ConvertMLIRModuleToTFLiteFlatBuffer( |
There was a problem hiding this comment.
This function body was copied from saved_model_tfl_flatbuffer.cc and then adjusted in the following ways:
- The
should_quantizeoption was added to make it work withgraphdef_tfl_flatbuffer.ccas well. - The
mark_as_post_training_quantoption was added to make it work withgraphdef_tfl_flatbuffer.ccas well.
Tombana
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This factors out some common code from
saved_model_tfl_flatbuffer.ccandgraphdef_tfl_flatbuffer.ccinto a new file. This already leads to some code de-duplication, but is mainly motivated to make future additions of similar functionality easier (e.g. a tflite-mlir-tflite converter).How Has This Been Tested?
CI should cover this I hope.
Related issue number
N/A