Remove manylinux container from CI #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
approved these changes
Jun 24, 2021
lgeiger
approved these changes
Jun 24, 2021
| - name: Run TFLite Ops and Core CC Unit Tests | ||
| run: ./bazelisk test larq_compute_engine/tests:cc_tests --copt=-O2 --distinct_host_configuration=false --test_output=all | ||
| - name: Install pip dependencies | ||
| run: pip install numpy --no-cache-dir |
There was a problem hiding this comment.
I think we also used to also need six for TF to build properly. Not sure if this is still the case.
Suggested change
| run: pip install numpy --no-cache-dir | |
| run: pip install numpy six --no-cache-dir |
There was a problem hiding this comment.
Thanks for the tip, lets see what CI does.
AdamHillier
approved these changes
Jun 24, 2021
lgeiger
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In our private fork we had problems where the manylinux container is too outdated for our unittests. Combined with the fact that it doesn't actually test anything (the tested code does not really overlap with the converter, which is the only thing that we use the manylinux container for), it makes more sense to remove the container from CI.
How Has This Been Tested?
CI