Skip to content

fix: Starter kits should not ignore the --database option #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

fix: Starter kits should not ignore the --database option #422

merged 1 commit into from
Jun 11, 2025

Conversation

mathiasgrimm
Copy link
Contributor

@mathiasgrimm mathiasgrimm commented Jun 11, 2025 •
edited
Loading

Current behaviour

SQLite will be used regardless of using the --database option

laravel new sk-3 --database pgsql

CleanShot 2025-06-11 at 10 12 34@2x

Expected behaviour

It should use the desired database driver

laravel new sk-1 --database pgsql

CleanShot 2025-06-11 at 10 02 57@2x

CleanShot 2025-06-11 at 10 02 09@2x

Validation

It validates invalid driver names

laravel new sk-2 --database invalid-driver-name

CleanShot 2025-06-11 at 10 09 34@2x

@taylorotwell taylorotwell merged commit 12edf32 into master Jun 11, 2025
21 checks passed
@taylorotwell taylorotwell deleted the fix-starter-kits-database-option branch June 11, 2025 14:55
@mathiasgrimm mathiasgrimm mentioned this pull request Aug 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joetannenbaum joetannenbaum Awaiting requested review from joetannenbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathiasgrimm @taylorotwell