Skip to content

[12.x] Localize “Pagination Navigation” aria-label #56103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andylolz
Copy link
Contributor

Fixes #56102.

This localizes the “Pagination Navigation” aria-label text for the simple Tailwind and simple Bootstrap 5 views, bringing them inline with the Tailwind view.

@andylolz andylolz changed the title Localize “Pagination Navigation” aria-label [12.x] Localize “Pagination Navigation” aria-label Jun 22, 2025
@taylorotwell taylorotwell merged commit 1d18684 into laravel:12.x Jun 22, 2025
62 checks passed
@andylolz andylolz deleted the 56102-localise-pagination-aria-label branch June 23, 2025 09:10
@AhmedAlaa4611
Copy link
Contributor

Why we used the {!! ... !!} syntax here not {{ ... }} as we already did here?

Illuminate/Pagination/resources/views/tailwind.blade.php

@andylolz
Copy link
Contributor Author

Why we used the {!! ... !!} syntax here not {{ ... }} as we already did here?

That’s a good point.

Though, other translations in this file use {!! … !!} e.g.

@AhmedAlaa4611
Copy link
Contributor

According to the last example here:

https://laravel.com/docs/12.x/localization#retrieving-translation-strings

I think we need to normalize them all to use {{ ... }}.

What do you think about that?

@andylolz
Copy link
Contributor Author

Seems reasonable to me.

I suggest opening a ticket about it, because I think there are quite a few translations that would need to be changed.

mohammad-fouladgar pushed a commit to mohammad-fouladgar/framework that referenced this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination views use unlocalized aria-labels
3 participants