[12.x] Pass TransportException to NotificationFailed event #56061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… event Prevents including the CurlResponse object that cannot be serialized with the NotificationFailed event.
mohammad-fouladgar
pushed a commit
to mohammad-fouladgar/framework
that referenced
this pull request
Jul 22, 2025
… event (laravel#56061) Prevents including the CurlResponse object that cannot be serialized with the NotificationFailed event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #56058.
When the Postmark mail driver receives a non-200 response, it throws an
HttpTransportExceptionthat contains aCurlResponseobject that is not serializable. This causes dispatching theNotificationFailedevent to fail when attempting to place it on the Queue. This PR checks for anHttpTransportExceptionand converts it to aTransportExceptionwithout theResponseobject before attaching it to the 'NotificationFailed' event.