[13.x] Adds starting method to Monitor interface #55950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Ullyott <[email protected]>
|
Tests failing. |
@taylorotwell tests are currently failing due to #55941 not being in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking change follow-up to #55941, adds the
startingmethod to theMonitorinterface to match the existence ofstoppingin this interface and thestartingmethod implemented insrc/Illuminate/Queue/QueueManager.php.This is failing CI as the changes merged in #55941 are not yet merged back into
master. If how this gets merged in needs to be changed I can wait on it.