-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[11.x] Non-default schema names #50019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Non-default schema names #50019
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Any breaking changes that will need to be documented here? |
@taylorotwell no, it's just a fix. |
Thanks! |
Hi @hafezdivandari Thanks for your effort to now fully support schema names in |
This PR adds tests for all schema operations with prefixed table and with custom schema name. Some schema methods were not working properly in these cases that are fixed on this PR:
Prefixed table
Non-default Schema name
Prefixed table on non-default schema
Most of schema operations wasn't working on this case, that is fixed now. Grammar was always prefixing the first segment of passed values, that causes a problem when passing a table as
schema.table
and being wrapped asprefix_schema.table
, this conditions is fixed by separating the logic for wrapping columns/values from wrapping tables after this PR:table.column
being wrapped toprefix_table.column
usingGrammar::wrap()
as before.schema.table
being wrapped asschema.prefix_table
usingGrammar::wrapTable()
as expected.P.S: This is just a fix and adds support for prefixed table and using non-default schema on all cases, it's not changing behavior so we don't need to add anything to upgrade guide.
Summary of tested and fixed cases