Skip to content

Document limiting client access to scopes in Passport #8979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

axlon
Copy link

@axlon axlon commented Aug 24, 2023

@taylorotwell taylorotwell marked this pull request as draft August 24, 2023 13:47
@taylorotwell taylorotwell marked this pull request as ready for review August 29, 2023 14:15
@taylorotwell taylorotwell marked this pull request as draft August 29, 2023 14:16
@bram-pkg
Copy link
Contributor

bram-pkg commented Feb 28, 2024

I just found the PR which merged this functionality after a long search for existing functionality. Any updates on this documentation PR? Do you need any help?

@hafezdivandari
Copy link
Contributor

@axlon why not update the migrations on Passport and add scopes column to the oauth_clients table by default?

@axlon
Copy link
Author

axlon commented Mar 6, 2024

@axlon why not update the migrations on Passport and add scopes column to the oauth_clients table by default?

@hafezdivandari this is definitely possible and might even be preferable now with strict mode, I didn't opt to do this at the time because grant_types was already an opt-in feature within passport that worked the same way (it also wasn't a part of the schema by default)

@driesvints
Copy link
Member

Hi there. We'd released v11 now. Please re-send this to 11.x if you still want to get this in. Thanks.

@driesvints driesvints closed this Mar 12, 2024
@mariomka
Copy link

mariomka commented Mar 3, 2025

It would be nice to add this to the docs. I spent a lot of time understanding it from the code. @axlon @driesvints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants