[FIX] Handle default table options in master slave connection. #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Could you rebase on top of 1.5? Would like to have this in for those using Laravel 6 (LTS). |
zackrowe
force-pushed
the
master-slave-connection-handle-default-table-options
branch
from
d1d2655 to
46b9de1
Compare
|
Please |
zackrowe
force-pushed
the
master-slave-connection-handle-default-table-options
branch
from
abe30df to
46b9de1
Compare
zackrowe
force-pushed
the
master-slave-connection-handle-default-table-options
branch
from
46b9de1 to
efda211
Compare
Yikes! Sorry about that. I guess I'm a little confused on how rebases are handled in my IDE. |
zackrowe
changed the title
|
It happens :) Released with 1.5.8 and 1.6.1, thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the doctrine
AbstractSchemaManager::createSchemaConfigis checking the top level of the settings array to see if thedefaultTableOptionsis set. When utilizing theMasterSlaveConnectionthis setting is nested within themasterandslavearrays and is getting ignored.Changes proposed in this pull request:
MasterSlaveConnection::resolve()function to check if this setting is set and add it to the top level of the returned array.MasterSlaveConnectionTestto verify that thedefaultTableOptionsare being handle properly.