[FEATURE] Add support for Laravel 7.x #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests pass and `DoctrineTokenRepository` updated with tests. Not tested on an application yet but changes are minor and should be fine. Would be useful if someone else could test as I have no production apps on Laravel 7 just yet.
barryo
added a commit
to barryo/acl
that referenced
this pull request
Mar 5, 2020
All tests pass, changes were minimal. Composer dependancies updated to match Laravel 7. NB: Should not be merged until laravel-doctrine/orm#438 is.
barryo
added a commit
to barryo/extensions
that referenced
this pull request
Mar 5, 2020
Also I have updated all tests to work with PHPUnit 8.5. All tests pass (with laravel-doctrine/orm 1.6 per PR laravel-doctrine/orm#438). Should be merged into a new branch: 1.2.
|
Great work @barryo! :) |
|
The following packages also needs to release new versions for L7 support. I will try to finish up the releases at the end of the week. |
|
Thanks for merging @eigan - I have open PRs for extensions and acl which should pass tests now that v1.6 is released. I missed migrations - if you don't get to it in the next couple days, I'll try. |
|
We need to upgrade to doctrine/migrations 2.0 for composer to be happy. Will take a look tomorrow. |
|
I did try to upgrade to migrations 2.0, but it went pretty bad. Lots of refactoring, so need to spend some time to get it right, which I currently do not have sadly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass and
DoctrineTokenRepositoryupdated with tests.Not tested on an application yet but changes are minor and should be
fine. Would be useful if someone else could test as I have no
production apps on Laravel 7 just yet.
No 1.6 or master branch to PR against.