Skip to content

[FEATURE] Laravel 6.0 #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 19, 2019
Merged

[FEATURE] Laravel 6.0 #394

merged 8 commits into from
Sep 19, 2019

Conversation

stephandesouza
Copy link
Contributor

Changes proposed in this pull request:

  • Bump Laravel 6.0
  • Upgrade phpunit - as used by Laravel 6 (and supported by 5.5)

@winkbrace
Copy link

Awesome job, hope it will be accepted soon :)

@eigan eigan mentioned this pull request Sep 6, 2019
Copy link
Member

@eigan eigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is targeting 1.4 which is fine because there is no other branch to target, but a maintainer should consider starting a new release branch and leave 1.4 for the 5.5, 5.6, 5.6, and 5.8 releases.

composer.json Outdated
"illuminate/view": "5.5.*|5.6.*|5.7.*|5.8.*",
"symfony/serializer": "^2.7|~3.0|~4.0"
"doctrine/orm": "2.5.*|2.6.*|2.7.*",
"illuminate/auth": "5.5.*|5.6.*|5.7.*|5.8.*|^6.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop support for 5.5? This version supports PHP 7.0 which is EOL now.

It would also allow us to merge #388.

I would prefer to drop all except 6.0. As Laravel 6.0 requires 7.2 and 7.1 is EOL later this year.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a maintainer agrees should the required PHP version also be updated.

@stephandesouza
Copy link
Contributor Author

stephandesouza commented Sep 7, 2019

There is no master branch to send this PR. But on Readme I already prepared this PR for a 1.5 version.

I agree with dropping EOL and near EOL versions of PHP and Laravel.

@patrickbrouwers patrickbrouwers changed the base branch from 1.4 to 1.5 September 19, 2019 09:21
@patrickbrouwers patrickbrouwers merged commit 14badce into laravel-doctrine:1.5 Sep 19, 2019
@patrickbrouwers
Copy link
Contributor

I'm not really involved in the project anymore, but seeing that unfortunately no one else went ahead and reviewed/merged it, I did so. New version will be released as 1.5 and will drop support for older Laravel and PHP versions.

@barryo
Copy link
Contributor

barryo commented Sep 19, 2019

Thanks for taking the time and making the effort to merge this @patrickbrouwers - much appreciated.

@stephandesouza
Copy link
Contributor Author

Thanks @patrickbrouwers

@winkbrace
Copy link

You're awesome Patrick ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants