[FIX] Missing state() function on Factory #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With laravel/framework 5.3.17, they have added states to model factories. Since function state() is called on every factory() (and entity()) calls, testing with Doctrines Factory will fail on undefined function.
This PR only supresses the error, but does not implement states functionality. It's up to you, if it should be merged.
Ideally, Laravel-Doctrine might adopt states functionality, since it is same, as defineAs functionality. It would be just more familiar to Laravel users. States have one advantage compared to defineAs - you can stack states up.
What approach do you think would be best for Laravel-Doctrine?