Make Ref Example Threadsafe #7383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
vowelparrot
force-pushed
the
wfh/example_assignment
branch
from
920dc5c to
830b773
Compare
vowelparrot
force-pushed
the
wfh/example_assignment
branch
from
830b773 to
78dbad3
Compare
vowelparrot
force-pushed
the
wfh/example_assignment
branch
from
baac134 to
78f7d44
Compare
Collaborator
Author
|
Added a test that fails on master to show it fixes it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have noticed transient ref example misalignment. I believe this is caused by the logic of assigning an example within the thread executor rather than before.