-
Notifications
You must be signed in to change notification settings - Fork 20.3k
Upgrade the AwaDB from 0.3.5 to 0.3.6 #7363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. support get, delete and update batch documents 2. add the implementation of max_marginal_relevance_search 3. change the vector's default distance from L2 to InnerProduct
Explicitly list requires_reference in function (langchain-ai#7357)
delete unnecessary annotation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adjust the code format of awadb.py for the awadb vectorstore
efriis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes! Main requested change is to align docstring on similarity_search_with_relevance_scores with the referenced types.
Looks like you removed the reference to relevance scores even though they're still present.
langchain/vectorstores/awadb.py
Outdated
| **kwargs: Any, | ||
| ) -> List[Document]: | ||
| """Return docs most similar to query.""" | ||
| """The most k similar documents of the specified text query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| """The most k similar documents of the specified text query. | |
| """Returns the k most similar documents to the specified text query. |
nit
langchain/vectorstores/awadb.py
Outdated
| Args: | ||
| query: Text query | ||
| k: The most k similar documents of the text query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| k: The most k similar documents of the text query | |
| k: The maximum number of documents to return |
langchain/vectorstores/awadb.py
Outdated
| kwargs: Any possible extend parameters in the future. | ||
| Returns: | ||
| The most k similar documents of the specified text query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The most k similar documents of the specified text query | |
| The k most similar documents to the specified text query |
langchain/vectorstores/awadb.py
Outdated
| 0 is dissimilar, 1 is most similar. | ||
| Returns: | ||
| List of Documents the most similar to the text query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| List of Documents the most similar to the text query. | |
| List of (Document, relevance_score) tuples the most similar to the text query. |
|
@efriis I have added and changed the notes about relevance scores. please check, thanks! |
|
@ljeagle looks like the formatter/lint check failed - could you update that and I can merge it in? |
ok, thanks |
|
Thanks @ljeagle ! |
Upgrade the AwaDB from 0.3.5 to 0.3.6
Please review @rlancemartin, @eyurtsev @hwchase17. Thanks!