adding max_marginal_relevance_search method to MongoDBAtlasVectorSearch #7310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
Author
|
@rlancemartin I fixed the linting. LGTM |
rlancemartin
reviewed
Jul 7, 2023
Contributor
rlancemartin
left a comment
rlancemartin
left a comment
There was a problem hiding this comment.
thanks! looks like there may be a formatting error w/ the notebook? i see invalid JSON when trying to view it.
Contributor
Author
@rlancemartin I fixed the JSON - trailing comma |
Collaborator
|
thanks @P-E-B! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a maximal_marginal_relevance method to the MongoDBAtlasVectorSearch vectorstore enhances the user experience by providing more diverse search results
Issue: #7304
@rlancemartin, @eyurtsev --> Please make sure that I'm using correctly the maximal_marginal_relevance (from utils).