add preset ability to textgen llm #7196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hwchase17
reviewed
Jul 5, 2023
| if self.preset is None: | ||
| params = self._default_params | ||
| else: | ||
| params = {"preset": self.preset} |
Contributor
There was a problem hiding this comment.
shouldnt this still use self._default params?
Contributor
Author
There was a problem hiding this comment.
it will use the preset defined in textgen, no need for additional params. all this params are defined in the preset.
Contributor
Author
There was a problem hiding this comment.
@hwchase17 is all the checks must pass? when it will be merged?
hwchase17
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an ability for textgen llm to work with preset provided by text gen webui API.
@hwchase17, @baskaryan