make textstat optional in the flyte callback handler #7186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
samhita-alla
changed the title
hwchase17
reviewed
Jul 5, 2023
| resp.update({"text_complexity_metrics": text_complexity_metrics}) | ||
| resp.update(text_complexity_metrics) | ||
| if textstat is not None: | ||
| textstat = import_textstat() |
Contributor
There was a problem hiding this comment.
this doesnt need to be here any more, right
Contributor
Author
There was a problem hiding this comment.
You're right. Removed the import.
Signed-off-by: Samhita Alla <[email protected]>
hwchase17
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
textstatlibrary optional in the Flyte callback handler.@hinthornw, would you mind reviewing this PR since you merged the flyte callback handler code previously?