Skip to content

Conversation

@ShantanuNair
Copy link
Contributor

  • Description: Add docs on how to set and use the token_max arg for MapReduceChains
  • Issue: Several issues have been repeatedly raised regarding this, since it is non-intuitive how to pass this arg. This makes usage with larger models such as gpt-3.5-turbo-16k much easier. I also explain how it's a sliding scale between how much the inputs will be summarized vs tokens left for generation.
  • Tag maintainer: @baskaryan @hwchase17
  • Twitter handle: More PRs incoming! :) https://twitter.com/ShantanuNair

Related Github discussion: https://github.com/hwchase17/langchain/discussions/2746
Related issues: #1349, #7043, #434, #6397, #6714, #6191

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 11, 2023 11:30am

@ShantanuNair
Copy link
Contributor Author

ShantanuNair commented Jul 5, 2023

Updated to reflect token_max arg in chain initialization from #7204

@hwchase17
Copy link
Contributor

i think it should be referencing #7204

@ShantanuNair ShantanuNair force-pushed the token-max-docs-mapreduce branch 6 times, most recently from 4792d53 to 7652903 Compare July 7, 2023 13:36
@ShantanuNair
Copy link
Contributor Author

@hwchase17 @baskaryan

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think ReduceDocumentsChain is mentioned anywhere before this? should we update the custom map reduce section first, so that this is better contextualized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baskaryan I'll get to that and update the PR.

@leo-gan
Copy link
Collaborator

leo-gan commented Sep 18, 2023

@ShantanuNair Hi , could you, please, resolve the merging issues? After that ping me and I push this PR for the review. Thanks!

@efriis
Copy link
Contributor

efriis commented Nov 2, 2023

Hey @ShantanuNair any chance you got around to resolving the merge conflicts?

@efriis
Copy link
Contributor

efriis commented Nov 2, 2023

Actually - I think most of these chains docs have been rewritten with LCEL. Closing this, and let me know if you think it's still important somewhere else!

@efriis efriis closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants