Remove None default value for FAISS relevance_score_fn
#7085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the `relevance_score_fn` parameter passed to to `FAISS.__init__()` was `None`, a `ValueError` would be raised during search. Since a default value is provided for this parameter in the constructor, there's not reason to ever set the function to `None`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Collaborator
|
thanks @mssalvatore! |
vowelparrot
pushed a commit
that referenced
this pull request
Jul 4, 2023
## Description The type hint for `FAISS.__init__()`'s `relevance_score_fn` parameter allowed the parameter to be set to `None`. However, a default function is provided by the constructor. This led to an unnecessary check in the code, as well as a test to verify this check. **ASSUMPTION**: There's no reason to ever set `relevance_score_fn` to `None`. This PR changes the type hint and removes the unnecessary code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type hint for
FAISS.__init__()'srelevance_score_fnparameter allowed the parameter to be set toNone. However, a default function is provided by the constructor. This led to an unnecessary check in the code, as well as a test to verify this check.ASSUMPTION: There's no reason to ever set
relevance_score_fntoNone.This PR changes the type hint and removes the unnecessary code.
Tag Maintainer
@rlancemartin @eyurtsev