Add Better Errors for Comparison Chain #7033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
vowelparrot
force-pushed
the
wfh/chain
branch
4 times, most recently
from
99e867b to
f3de5c4
Compare
Collaborator
|
looks like this needs to be stacked ontop of #6942 |
Collaborator
Author
agola11
approved these changes
Jul 6, 2023
If a string evaluator doesn't want references, it currently silently ignores any that are passed in. This PR proposes to warn once if they're provided. It does so via a mixin. Other options we could do: - Separate classes for criteria with references and comparisons with references - I don't love this because all the combinations lead to class explosion and the class names themselves are ugly (CriteriaWithReferencesNoLabels, etc.) - Raise errors if they're provided - I don't like this because it requires more checks when running evaluators over a dataset, but would be more explicit. - Decide at calling time -> could be a lot of partial prompt insertions that makes it more brittle. Would make a single "run" potentially have two results that are fundamentally different evaluations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.