Fix callback forwarding in async plan method for OpenAI function agent #6584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
QodoAI-Agent
left a comment
QodoAI-Agent
left a comment
There was a problem hiding this comment.
PR Analysis
- 🎯 Main theme: This PR fixes an issue with callback forwarding in the async plan method for the OpenAI function agent.
- 🔍 Description and title: yes
- 📌 Type of PR: Bug fix
- 🐞 Bug description: The callback argument was missing in the async plan method, which prevented callbacks from working properly when using the method asynchronously.
- 🧪 Relevant tests added: no
⚠️ Unrelated changes: no- ✨ Minimal and focused: yes
PR Feedback
-
💡 Suggestions: Please add tests to verify that the callback functionality works as expected after the fix.
-
🌱 Minor suggestions: Consider adding a docstring to the
aplanmethod to explain its purpose and usage, including the callback functionality. -
🤖 Code Suggestions:
- In file
base.py: Add a test case in the test suite for the OpenAI function agent that checks if the callback is properly forwarded and executed when using theaplanmethod asynchronously. [important]
- In file
QodoAI-Agent
left a comment
QodoAI-Agent
left a comment
There was a problem hiding this comment.
PR Analysis
- 🎯 Main theme: This PR fixes the missing callback argument in the async plan method for OpenAI function agent.
- 🔍 Description and title: yes
- 📌 Type of PR: Bug fix
- 🐞 Bug description: The callback argument was missing in the async plan method, preventing callbacks from working properly when using it asynchronously.
- 🧪 Relevant tests added: no
⚠️ Unrelated changes: no- ✨ Minimal and focused: yes
PR Feedback
- 💡 Suggestions: Please add a test case to demonstrate the bug and the fix.
- 🤖 Code Suggestions:
Contributor
|
thanks @rogeriochaves! |
tconkling
added a commit
to tconkling/langchain
that referenced
this pull request
Jun 22, 2023
* master: MD header text splitter returns Documents (langchain-ai#6571) Fix callback forwarding in async plan method for OpenAI function agent (langchain-ai#6584) bump 209 (langchain-ai#6593) Clarifai integration (langchain-ai#5954) Add missing word in comment (langchain-ai#6587) Add AzureML endpoint LLM wrapper (langchain-ai#6580) Add OpenLLM wrapper(langchain-ai#6578) feat: interfaces for async embeddings, implement async openai (langchain-ai#6563) Upgrade the version of AwaDB and add some new interfaces (langchain-ai#6565) add motherduck docs (langchain-ai#6572) Detailed using the Twilio tool to send messages with 3rd party apps incl. WhatsApp (langchain-ai#6562) Change Data Loader Namespace (langchain-ai#6568) Remove duplicate databricks entries in ecosystem integrations (langchain-ai#6569) Fix whatsappchatloader - enable parsing new datetime format on WhatsApp chat (langchain-ai#6555) Wait for all futures (langchain-ai#6554) feat: faiss filter from list (langchain-ai#6537) update pr tmpl (langchain-ai#6552) Remove unintended double negation in docstring (langchain-ai#6541) Minor Grammar Fixes in Docs and Comments (langchain-ai#6536)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback argument was missing, preventing me to get callbacks to work properly when using it async