Add tags in agent initialization #6559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
vowelparrot
commented
Jun 21, 2023
| ) | ||
| try: | ||
| # TODO: Add tags from the serialized object directly. | ||
| tags_.append(agent_obj._agent_type) |
Contributor
Author
There was a problem hiding this comment.
Not sure why this isn't giving a lint error. Also fine removing this bit. Also could add in a root validator put in the class initializer in case people aren't using this method all the time.
QodoAI-Agent
left a comment
QodoAI-Agent
left a comment
There was a problem hiding this comment.
PR Analysis
- 🎯 Main theme: This PR adds tags to the agent initialization and improves docstrings in the agent executor.
- 🔍 Description and title: yes
- 📌 Type of PR: Enhancement
- 🧪 Relevant tests added: no
⚠️ Unrelated changes: no- ✨ Minimal and focused: yes
PR Feedback
-
💡 Suggestions: Consider adding tests to ensure the tags are applied correctly during agent initialization.
-
🌱 Minor suggestions: In the docstring for
handle_parsing_errors, there is an extra 's' on a new line. Please remove it. -
🤖 Code Suggestions:
- In file
langchain/agents/initialize.py: It would be better to use a more descriptive variable name fortags_. Consider renaming it toapplied_tags. [minor]
- In file
nfcampos
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add better docstrings for agent executor as well
Inspo: langchain-ai/langchainjs#1722
