Harrison/multi tool #6518
Merged
Harrison/multi tool #6518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jxnl
reviewed
Jun 21, 2023
| "type": "object", | ||
| "properties": { | ||
| "tool_name": { | ||
| "title": "Tool Name", |
Contributor
There was a problem hiding this comment.
not sure if relevant but i think having descriptions can help with correct usage. but i noticed that its based on enum of tool name rather than the tools properties.
jxnl
reviewed
Jun 21, 2023
|
|
||
| for intermediate_step in intermediate_steps: | ||
| agent_action, observation = intermediate_step | ||
| messages.extend(_convert_agent_action_to_messages(agent_action, observation)) |
Contributor
There was a problem hiding this comment.
Suggested change
| messages.extend(_convert_agent_action_to_messages(agent_action, observation)) | |
| return [ | |
| _convert_agent_action_to_messages(agent_action, observation) | |
| for (agent_action, observation) in intermediate_steps | |
| ] |
dev2049
reviewed
Jun 21, 2023
Contributor
dev2049
left a comment
dev2049
left a comment
There was a problem hiding this comment.
should add it to docs/modules/agents/agent_types (could just add as a notebook)
| """An Agent driven by OpenAIs function powered API. | ||
|
|
||
| Args: | ||
| llm: This should be an instance of ChatOpenAI, specifically a model |
| return messages | ||
|
|
||
|
|
||
| def _parse_ai_message(message: BaseMessage) -> Union[List[AgentAction], AgentFinish]: |
| @classmethod | ||
| def create_prompt( | ||
| cls, | ||
| system_message: Optional[SystemMessage] = SystemMessage( |
Contributor
There was a problem hiding this comment.
are messages mutable? default None instead?
| **kwargs: Any, | ||
| ) -> BaseMultiActionAgent: | ||
| """Construct an agent from an LLM and tools.""" | ||
| if not isinstance(llm, ChatOpenAI): |
Contributor
There was a problem hiding this comment.
checked by validator already
| cls, | ||
| llm: BaseLanguageModel, | ||
| tools: Sequence[BaseTool], | ||
| callback_manager: Optional[BaseCallbackManager] = None, |
Contributor
There was a problem hiding this comment.
why do we need callback_manager explicitly listed? also isn't that deprecated
| @property | ||
| def functions(self) -> List[dict]: | ||
| enum_vals = [t.name for t in self.tools] | ||
| tool_selection = { |
Contributor
There was a problem hiding this comment.
could we make this more easily customizable? like if someone wanted to test out different descriptions or names they'd have to subclass and overwrite this property (or rewrite from scratch). could make functions a init param that has a default
tconkling
added a commit
to tconkling/langchain
that referenced
this pull request
Jun 21, 2023
* master: (28 commits) [Feature][VectorStore] Support StarRocks as vector db (langchain-ai#6119) Relax string input mapper check (langchain-ai#6544) bump to ver 208 (langchain-ai#6540) Harrison/multi tool (langchain-ai#6518) Infino integration for simplified logs, metrics & search across LLM data & token usage (langchain-ai#6218) Update model token mappings/cost to include 0613 models (langchain-ai#6122) Fix issue with non-list `To` header in GmailSendMessage Tool (langchain-ai#6242) Integrate Rockset as Vectorstore (langchain-ai#6216) Feat: Add a prompt template parameter to qa with structure chains (langchain-ai#6495) Add async support for HuggingFaceTextGenInference (langchain-ai#6507) Be able to use Codey models on Vertex AI (langchain-ai#6354) Add KuzuQAChain (langchain-ai#6454) Update index.mdx (langchain-ai#6326) Export trajectory eval fn (langchain-ai#6509) typo(llamacpp.ipynb): 'condiser' -> 'consider' (langchain-ai#6474) Fix typo in docstring of format_tool_to_openai_function (langchain-ai#6479) Make streamlit import optional (langchain-ai#6510) Fixed: 'readible' -> readable (langchain-ai#6492) Documentation Fix: Correct the example code output in the prompt templates doc (langchain-ai#6496) Fix link (langchain-ai#6501) ...
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.