Skip to content

Conversation

@davidbuniat
Copy link
Contributor

@davidbuniat davidbuniat commented Jun 18, 2023

Hot Fixes for Deep Lake [would highly appreciate expedited review]

  • deeplake version was hardcoded and since deeplake upgraded the integration fails with confusing error
  • an additional integration test fixed due to embedding function
  • Additionally fixed docs for code understanding links after docs upgraded
  • notebook removal of public parameter to make sure code understanding notebook works

Who can review?

@hwchase17 @dev2049

@vercel
Copy link

vercel bot commented Jun 18, 2023

Someone is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jun 18, 2023 10:10pm

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@hwchase17 hwchase17 merged commit 1ab9dc8 into langchain-ai:master Jun 19, 2023
@davidbuniat
Copy link
Contributor Author

thanks @hwchase17 @vowelparrot for your prompt follow up!

@karencfisher
Copy link

I just encountered this with version 3.6.5. Version check has not been updated, and is inconsistent as well. I.e., in deeplake.py, 127-132:

version = deeplake.__version__
if version != "3.6.2":
       raise ValueError(
            "deeplake version should be = 3.6.3, but you've installed"
             f" {version}. Consider changing deeplake version to 3.6.3 ."
        )

(This check will fail if version is 3.6.3!)

Suggestion (tested on my local installation):

  1. define minimum_version globally, e.g., about line 23:
minimum_version = "3.6.3"
  1. Modify version check to:
version = deeplake.__version__
if not version >= minimum_version:      
       raise ValueError(
            f"deeplake version should be >= {minimum_version}, but you've installed"
            f" {version}. Consider changing deeplake version to {minimum_version} or later ."
        )
  1. Update one line of code when updating version, if necessary.

@davidbuniat
Copy link
Contributor Author

@karencfisher which version of langchain are you using?

This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants