Skip to content

Conversation

@hwchase17
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ❌ Failed (Inspect) Jun 16, 2023 2:27am

@vercel vercel bot temporarily deployed to Preview June 15, 2023 21:37 Inactive
@jxnl
Copy link
Contributor

jxnl commented Jun 15, 2023

only two small things

  1. not sure i see the 'force function_call' argument
    https://github.com/jxnl/openai_function_call/blob/main/example_segmentation.py#L61

doing function_call={"name": ...} on Completion.create

the api to force the usage, maybe abstracted away and already there, not sure

  1. In the docs its worth calling out that the docstring will be part of the schema 'prompt' and cna contain additional rules and information.

https://github.com/jxnl/openai_function_call/blob/main/example_segmentation.py#L36-L42https://github.com/jxnl/openai_function_call/blob/main/example_segmentation.py#L36-L42

  1. I don't see any validation after the json is returned when pydantic is being used (does it go back to return json.loads)? see:
    https://github.com/jxnl/openai_function_call/blob/main/openai_function_call.py#L63

@vercel vercel bot temporarily deployed to Preview June 16, 2023 02:27 Inactive
@hwchase17 hwchase17 merged commit 6aafb46 into master Jun 16, 2023
@hwchase17 hwchase17 deleted the harrison/openai-functions branch June 16, 2023 04:43
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants