qdrant: search by vector #6043
Merged
qdrant: search by vector #6043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @kacperlukawski |
kacperlukawski
suggested changes
Jun 13, 2023
Contributor
There was a problem hiding this comment.
@otwieracz Looks fine. Thanks for implementing that! Could you please run make format and make lint (and fix the issues, if any)? Otherwise, it won't pass the CI checks. Once it's done, it is ready to be merged.
Contributor
|
@otwieracz It seems the |
Contributor
Author
|
@kacperlukawski Thanks for pointing that. Fixed the type hint, reformatted and these are linter results: |
|
@dev2049 Bumping up this request. Thanks in advance! |
hwchase17
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to
search_by_vectorto Qdrant Vector store.Who can review
VectorStores / Retrievers / Memory