Skip to content

Conversation

@ofermend
Copy link
Contributor

@ofermend ofermend commented Jun 9, 2023

This PR updates the Vectara integration (@hwchase17 ):

  • Adds reuse of requests.session to imrpove efficiency and speed.
  • Utilizes Vectara's low-level API (instead of standard API) to better match user's specific chunking with LangChain
  • Now add_texts puts all the texts into a single Vectara document so indexing is much faster.
  • updated variables names from alpha to lambda_val (to be consistent with Vectara docs) and added n_context_sentence so it's available to use if needed.
  • Updates to documentation and tests

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hwchase17 hwchase17 added the lgtm label Jun 10, 2023
@hwchase17 hwchase17 merged commit f8cf09a into langchain-ai:master Jun 10, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
This PR updates the Vectara integration (@hwchase17 ):
* Adds reuse of requests.session to imrpove efficiency and speed.
* Utilizes Vectara's low-level API (instead of standard API) to better
match user's specific chunking with LangChain
* Now add_texts puts all the texts into a single Vectara document so
indexing is much faster.
* updated variables names from alpha to lambda_val (to be consistent
with Vectara docs) and added n_context_sentence so it's available to use
if needed.
* Updates to documentation and tests

---------

Co-authored-by: Harrison Chase <[email protected]>
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants