Skip to content

Conversation

@vowelparrot
Copy link
Contributor

@vowelparrot vowelparrot commented Jun 6, 2023

Seems natural to try to disable logging by setting MY_VAR=false rather than unsetting (especially once you've already set it in the background)

@vowelparrot vowelparrot requested a review from hwchase17 June 6, 2023 14:20
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnake

@hwchase17 hwchase17 merged commit 0cfaa76 into master Jun 6, 2023
@hwchase17 hwchase17 deleted the vwp/false branch June 6, 2023 16:26
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
Seems natural to try to disable logging by setting `MY_VAR=false` rather
than unsetting (especially once you've already set it in the background)
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants