feat: issue-5712 add sleep tool #5715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vowelparrot
reviewed
Jun 5, 2023
| - Requires LLM: No | ||
| - Extra Parameters: `openweathermap_api_key` (your API key to access this endpoint) | ||
|
|
||
| **sleep** |
Contributor
There was a problem hiding this comment.
Let's add to langchain/agents/load_tools.py for this one!
Contributor
|
Thanks for the PR! one main request - I'm also curious what you've found this useful for :) |
Contributor
Author
If we need to start a long-running job (for example we have a custom tool with a script that runs for several minutes or hours and save results in DB), an agent needs to wait for these results just doing nothing. |
hwchase17
approved these changes
Jun 5, 2023
Contributor
hwchase17
left a comment
hwchase17
left a comment
There was a problem hiding this comment.
looks reasonable to me - thanks!
Contributor
Author
|
@hwchase17 @vowelparrot Finally all tests passed :-). Any other concerns? |
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
Fixes # 5712 added sleep tool
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 5712 added sleep tool
Who can review?
@vowelparrot